feat(bundler): add --windows-icon, --windows-no-console, fix bun.exe's main icon #15894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-conway
force-pushed
the
dave/windows-icon
branch
from
8116f33 to
a107463
Compare
dylan-conway
approved these changes
Dec 20, 2024
Co-authored-by: Dylan Conway <35280289+dylan-conway@users.noreply.github.com>
Jarred-Sumner
requested changes
Dec 20, 2024
|
Does not fix Bun's own icon. But it's better than status quo. |
|
I love bun ~ |
|
@paperdave @Jarred-Sumner see resedit-cli and their resedit and pe-library npm packages for a pure JS solution for patching windows executables. I've been already using them for Neutralino, NW.JS and Bun binaries for a long time to edit and sign windows executables in a Linux CI, both in Node.js and Bun.
Plus you can use the |
|
Here is what I'm doing in my Buntralino — I implemented icon addition and no-console before this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing tests because writing one is very non-trivial.
--windows-iconis currently gated to windows build hosts (no cross compilation), as the current approach uses a library that calls the Windows API. In the future, we should replace this with a portable version that just manipulates the bytes in-memory.Fixes #10823
Fixes #13084